[MLv2] joinable-columns on a Join sets source and alias
#39529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(joinable-columns query stage a-join)` previously returned `:lib/source :source/table-defaults` and set `:metabase.lib.join/join-alias` but not `:source-alias`. This corrects both issues so that `joinable-columns` on a join returns columns with the same shape as from `visible-columns`. Also refactors a series of `mapv` transforms into a transducer pipeline. Fixes #39514.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bshepherdson and the rest of your teammates on |
|
ranquild
approved these changes
Mar 4, 2024
bshepherdson
added
backport
lbrdnk
approved these changes
Mar 4, 2024
|
@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
`(joinable-columns query stage a-join)` previously returned `:lib/source :source/table-defaults` and set `:metabase.lib.join/join-alias` but not `:source-alias`. This corrects both issues so that `joinable-columns` on a join returns columns with the same shape as from `visible-columns`. Also refactors a series of `mapv` transforms into a transducer pipeline. Fixes #39514.
metabase-bot bot
added a commit
that referenced
this pull request
Mar 4, 2024
…39543) `(joinable-columns query stage a-join)` previously returned `:lib/source :source/table-defaults` and set `:metabase.lib.join/join-alias` but not `:source-alias`. This corrects both issues so that `joinable-columns` on a join returns columns with the same shape as from `visible-columns`. Also refactors a series of `mapv` transforms into a transducer pipeline. Fixes #39514. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(joinable-columns query stage a-join)previously returned:lib/source :source/table-defaultsand set:metabase.lib.join/join-aliasbut not:source-alias.This corrects both issues so that
joinable-columnson a join returnscolumns with the same shape as from
visible-columns.Also refactors a series of
mapvtransforms into a transducer pipeline.Fixes #39514.