New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes after css modules migration #39531
Conversation
@@ -9,11 +9,6 @@ | |||
margin-right: auto; | |||
} | |||
|
|||
.list-wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed as it is not used anywhere.
Not related to reported issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed fixes the two things I pointed out (the circular back button, and the cards behind the two options in the "new model" screen).
Another item I noticed that could be related is that we're missing cursor: pointer
on hover when hovering on the filter and summarization elements of the notebook editor:
I checked, and this case is not related to css migration. It seems it is affected by MLv2 conversion project. |
@deniskaber Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Relates to #38811
Description
This fixes two issues reported after css modules migration from global to local scope:
How to verify
Describe the steps to verify that the changes are working as expected.
Open a dashboard, navigate to a question by clicking on a card title. Back button should be round.
Try to create a new model. Cards should have background and shadow.