Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes after css modules migration #39531

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

deniskaber
Copy link
Contributor

Relates to #38811

Description

This fixes two issues reported after css modules migration from global to local scope:

image

image

How to verify

Describe the steps to verify that the changes are working as expected.

  1. Open a dashboard, navigate to a question by clicking on a card title. Back button should be round.

  2. Try to create a new model. Cards should have background and shadow.

@deniskaber deniskaber self-assigned this Mar 4, 2024
@deniskaber deniskaber requested review from a team and mazameli March 4, 2024 15:51
@@ -9,11 +9,6 @@
margin-right: auto;
}

.list-wrapper {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed as it is not used anywhere.
Not related to reported issues

@deniskaber deniskaber added the no-backport Do not backport this PR to any branch label Mar 4, 2024
Copy link

replay-io bot commented Mar 4, 2024

Status Complete ↗︎
Commit 53ac3d4
Results
⚠️ 1 Flaky
2344 Passed

Copy link
Contributor

@mazameli mazameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the two things I pointed out (the circular back button, and the cards behind the two options in the "new model" screen).

Another item I noticed that could be related is that we're missing cursor: pointer on hover when hovering on the filter and summarization elements of the notebook editor:

image

@deniskaber
Copy link
Contributor Author

@mazameli ,

Another item I noticed that could be related is that we're missing cursor: pointer on hover when hovering on the filter and summarization elements of the notebook editor:

I checked, and this case is not related to css migration. It seems it is affected by MLv2 conversion project.

@deniskaber deniskaber enabled auto-merge (squash) March 4, 2024 20:01
@deniskaber deniskaber merged commit 7d6ba47 into master Mar 4, 2024
119 of 139 checks passed
@deniskaber deniskaber deleted the 38811-no-global-css-hotfix branch March 4, 2024 20:18
Copy link

github-actions bot commented Mar 4, 2024

@deniskaber Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@deniskaber deniskaber added this to the 0.49 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/Embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants