Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 backported "[QP] Use the alias for unfolded JSON columns from previous stages" #39536

Merged
merged 1 commit into from
Mar 4, 2024
Merged

🤖 backported "[QP] Use the alias for unfolded JSON columns from previous stages" #39536

merged 1 commit into from
Mar 4, 2024

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Mar 4, 2024

@metabase-bot metabase-bot bot added the was-backported apply this to PRs that are themselves backports label Mar 4, 2024
@metabase-bot metabase-bot bot requested a review from camsaul as a code owner March 4, 2024 16:30
@metabase-bot metabase-bot bot enabled auto-merge (squash) March 4, 2024 16:30
@replay-io replay.io
Copy link

replay-io bot commented Mar 4, 2024 •
edited

Status Complete ↗︎
Commit 899d44c
Results
⚠️ 1 Flaky
✅ 2324 Passed

@bshepherdson
[QP] Use the alias for unfolded JSON columns from previous stages (#3…
899d44c 
…9446)

In the legacy QP the `:fields` of the outer query has the ID,
`[:field 100 {}]` so the JSON unfolding is written out again.

With this change, the `source-alias` is used for columns coming from
previous stages.

Fixes #34930. Fixes #35636.
@bshepherdson bshepherdson force-pushed the backport-f965d08815e804b45f6dd0a7aaa424c050e45a51 branch from ce68d3d to 899d44c Compare March 4, 2024 19:36
@metabase-bot metabase-bot bot merged commit 38e9a6a into release-x.49.x Mar 4, 2024
105 checks passed
@metabase-bot metabase-bot bot deleted the backport-f965d08815e804b45f6dd0a7aaa424c050e45a51 branch March 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@bshepherdson bshepherdson

Labels
was-backported apply this to PRs that are themselves backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bshepherdson