Fix click behavior not working for pivot table header cells and tables pivoted (pivoted column cells) #39569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseSDevaney
added
Visualization/Tables
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 20211d0...93da304.
|
|
kulyk
requested changes
Mar 5, 2024
…ivot-tables-and-tables-pivoted
kulyk
approved these changes
Mar 5, 2024
JesseSDevaney
deleted the
25203/fix-click-behavior-not-working-for-pivot-tables-and-tables-pivoted
branch
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
…s pivoted (pivoted column cells) (#39569) * update pivot table header cells clicked format to match the expected format * fix clicked table pivoted click behavior for the chosen pivot column * fix failing tests * add tests
metabase-bot bot
added a commit
that referenced
this pull request
Mar 6, 2024
…s pivoted (pivoted column cells) (#39569) (#39663) * update pivot table header cells clicked format to match the expected format * fix clicked table pivoted click behavior for the chosen pivot column * fix failing tests * add tests Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
|
@JesseSDevaney How hard is it to backport this to 48? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
2024-03-04.16-06-31.mp4
After
2024-03-04.16-02-54.mp4