Dashboard width revision message should handle nil #39710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though there shouldn't be `nil` values in dashboard.width, because the migration populates w/ the default value of `full`, it is still true that because of the version before the migration, revisions can have `nil` for the width value. The diff string impl didn't consider this, causing an NPE with `(name nil)`.
|
adam-james-v
added
the
backport
camsaul
approved these changes
Mar 6, 2024
@camsaul, I made a slight modification and added a test. It's probably still ok, but a quick second look might be good, if you have a second. |
camsaul
approved these changes
Mar 7, 2024
adam-james-v
deleted the
bugfix-38910-dashboard-width-revision-message-should-handle-nil
branch
|
@adam-james-v Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Revision Diff Should handle `nil` Dashboard Width Even though there shouldn't be `nil` values in dashboard.width, because the migration populates w/ the default value of `full`, it is still true that because of the version before the migration, revisions can have `nil` for the width value. The diff string impl didn't consider this, causing an NPE with `(name nil)`. * Use :guard to prevent nil values from matching * Add test checking that dashboard width change is described correctly
metabase-bot bot
added a commit
that referenced
this pull request
Mar 7, 2024
* Revision Diff Should handle `nil` Dashboard Width Even though there shouldn't be `nil` values in dashboard.width, because the migration populates w/ the default value of `full`, it is still true that because of the version before the migration, revisions can have `nil` for the width value. The diff string impl didn't consider this, causing an NPE with `(name nil)`. * Use :guard to prevent nil values from matching * Add test checking that dashboard width change is described correctly Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38910
Even though there shouldn't be
nilvalues in:widthkeys on the dashboard, (because the migration populates w/ the default value offull), it is still true that because of the version before the migration, revisions can havenilfor the widthvalue. The diff string impl didn't consider this, causing an NPE with
(name nil).This change should guard the diff string from trying to run on these
nilvalues.