Fix janky db refreshing #39796
Merged
Fix janky db refreshing #39796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
added
the
backport
rafpaf
force-pushed
the
fix-39732-janky-db-refreshing
branch
from
60214b3
to
165ca0b
Compare
|
let's backport this to 49, it's a simple bugfix for a feature in 49 (milestone should be 49) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39732
Description
The problem is that when a new database is added, the tables are handled in a background process which updates the data available through
/api/database. The Browse databases page pulls in data from that endpoint. But when the endpoint has fresh data to provide, the page goes into a loading state for a split second, causing the page to instantly scroll back up to the top, which is annoying.This PR fixes the problem by showing the loading spinner only when there are no databases already loaded into the page.
Loom