🤖 backported "Properly highlight models as the data source" #39799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![metabase-bot[bot]](https://avatars.githubusercontent.com/in/220029?s=60&v=4){kind=small}
metabase-bot
bot
added
the
was-backported
* [HDS] Prep/cleanup steps for Highlighting the data source (#39681) * Rename `DATA_BUCKET` key to `MODELS` * Rename misleading method `isSavedQuestionSelected` is too narrow because we can also have other saved entities, such as models (and soon metrics) as the selected source. * Fix type for `selectedTableId` * Extract `sourceId` * Rename saved question instances to saved entity * Rename related components * Show models correctly in the data source picker (#39686) * Show models correctly in the data source picker * Address review comments * Destructure props * Add E2E reproduction for #39699 * Prevent accessing potentially stale value Closes #39699
nemanjaglumac
force-pushed
the
backport-8a4e14cd21d799527722a856b790d4959dc48a5e
branch
from
08f9a69
to
56d4c48
Compare
|
uladzimirdev
approved these changes
Mar 7, 2024
nemanjaglumac
deleted the
backport-8a4e14cd21d799527722a856b790d4959dc48a5e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39792.
Manual conflict resolution.
frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx was quite different from the one in
master, so I had to carefully apply only the related changes.Luckily, a related E2E test was backported as well, and that should give us some confidence that the things are working as expected.