No view logging for oss #39957
Merged
No view logging for oss #39957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
noahmoss
approved these changes
Mar 11, 2024
escherize
added
the
backport
- check for `log-enabled?` not `ee-available?`
…e into no-view-logging-for-oss
- Only check for view logs when (premium-features/log-enabled?) is falsey
escherize
added a commit
that referenced
this pull request
Mar 12, 2024
* move log-enabled? into premium-features * only `record-views!` when `log-enabled?` * test that view-log entries arent created in oss * simplify test * fix new test fails: we don't log views in OSS. * fix 3 more view logging tests (they dont do anything in oss) * fix dashboard-read-ee-test - check for `log-enabled?` not `ee-available?` * fix the rest of the tests - Only check for view logs when (premium-features/log-enabled?) is falsey * adjusting e2e test --------- Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on fix for #35288
We mustn't record view logging in OSS, but we were anyway.