Global to local css migration - grabber #40007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskaber
force-pushed
the
38811-no-global-css-migration-1
branch
from
ffdad00
to
9cc0e08
Compare
deniskaber
force-pushed
the
38811-no-global-css-migration-2
branch
2 times, most recently
from
2cc6eaa
to
ea46466
Compare
deniskaber
changed the base branch from
38811-no-global-css-migration-1
to
38811-no-global-css-query-builder
deniskaber
changed the title
|
deniskaber
changed the title
| @@ -100,6 +100,7 @@ | |||
|
|
|||
| /* white - move to bottom for specificity since its often used on hovers, etc */ | |||
| :global(.text-white), | |||
| .text-white, | |||
There was a problem hiding this comment.
do we still need to add this one?
oisincoveney
approved these changes
Mar 18, 2024
deniskaber
force-pushed
the
38811-no-global-css-migration-2
branch
from
8e759b6
to
2d348ce
Compare
deniskaber
changed the base branch from
38811-no-global-css-query-builder
to
master
deniskaber
force-pushed
the
38811-no-global-css-migration-2
branch
from
2d348ce
to
354a08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #38811 , Milestone 2
Description
This migrates global CSS rules from
grabber.module.cssto be locally scoped.How to verify