Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interpolate missing values setting on stacked areas #40041

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented Mar 12, 2024

Closes #38682

Description

Fixes stacked areas with "Replace missing values with Linear interpolated" setting. Here is the visual explanation of how it works:
Screenshot 2024-03-12 at 5 22 53 PM

How to verify

Ensure stacked area chart with "Replace missing values with Linear interpolated":

  • interpolates area polygons when all series have nulls
  • replaces nulls with zeros if at least one series in the dataset has non-null value

Example query

select 1 x, 10 y1, 20 y2, 30 y3
union all select 2, 10, null, 30
union all select 3, null, null, 30
union all select 4, null, null, null
union all select 5, 10, null, 30

Demo

Before
Screenshot 2024-03-12 at 5 28 35 PM

After
Screenshot 2024-03-12 at 5 24 13 PM

DC.js
Screenshot 2024-03-12 at 5 22 44 PM

Checklist

  • Tests have been added/updated to cover changes in this PR

@alxnddr alxnddr self-assigned this Mar 12, 2024
@metabase-bot metabase-bot bot added .Team/DashViz Dashboard and Viz team visual Run Percy visual testing labels Mar 12, 2024
Copy link

replay-io bot commented Mar 12, 2024

Status Complete ↗︎
Commit 6cb027f
Results
177 Failed
⚠️ 1 Flaky
2039 Passed

@alxnddr alxnddr merged commit f44b277 into echarts Mar 13, 2024
81 of 115 checks passed
@alxnddr alxnddr deleted the fix-stacked-areas-interpolate-missing-values branch March 13, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/DashViz Dashboard and Viz team visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants