Elevate selected filter field values #40055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
added
the
backport
ranquild
commented
Mar 13, 2024
| @@ -242,6 +242,66 @@ describe("StringFilterValuePicker", () => { | |||
| expect(onChange).toHaveBeenCalledWith(["t", "p"]); | |||
| }); | |||
|
|
|||
| it("should elevate selected field values on initial render", async () => { | |||
There was a problem hiding this comment.
All tests here with custom remapping to handle the most advance case.
|
| query={query} | ||
| stageIndex={stageIndex} | ||
| column={column} | ||
| values={["p", "c"]} |
There was a problem hiding this comment.
Let's also make sure that unchecking values doesn't move the items.
This can be a separate test case, or this one:
Suggested change
| values={["p", "c"]} | |
| values={["c"]} |
plus expect(checkboxes[0]).not.toBeChecked();
| @@ -57,7 +57,7 @@ async function setupStringPicker({ | |||
| setupFieldSearchValuesEndpoints(result.field_id, value, result.values); | |||
| }); | |||
|
|
|||
| renderWithProviders( | |||
| const { rerender } = renderWithProviders( | |||
There was a problem hiding this comment.
Should this case be handled too?
2024-03-13.18-52-36.mp4
There was a problem hiding this comment.
Fixed, great catch!
kamilmielnik
approved these changes
Mar 13, 2024
|
@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product doc https://www.notion.so/metabase/Show-the-selected-filter-values-on-top-of-multi-select-list-6e3f2e1880dc40bc8c50170236ca0aaa
Elevate selected field values on initial render when rendering them as a list of checkboxes.
How to verify: