Global to local css migration - Buttons #40103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskaber
added
.Team/Embedding
no-backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f73b40c...b2d6570.
|
|
deniskaber
force-pushed
the
38811-no-global-css-buttons
branch
from
bea1d89
to
daf2659
Compare
deniskaber
force-pushed
the
38811-no-global-css-buttons
branch
from
daf2659
to
cf3e54b
Compare
oisincoveney
approved these changes
Mar 14, 2024
oisincoveney
approved these changes
Mar 14, 2024
# Conflicts: # frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.jsx # frontend/src/metabase/admin/datamodel/metadata/components/MetadataTableSettings/MetadataTableSettings.tsx # frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.jsx # frontend/src/metabase/components/DeleteModalWithConfirm/DeleteModalWithConfirm.jsx # frontend/src/metabase/core/components/Button/Button.tsx # frontend/src/metabase/css/core/colors.module.css # frontend/src/metabase/dashboard/components/AddSeriesModal/AddSeriesModal.tsx # frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeader.tsx # frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderView.tsx # frontend/src/metabase/query_builder/components/AlertModals.jsx # frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditor.jsx # frontend/src/metabase/query_builder/components/QueryVisualization.jsx # frontend/src/metabase/reference/components/EditHeader.jsx # frontend/src/metabase/reference/components/ReferenceHeader.jsx # frontend/src/metabase/sharing/components/AddEditSidebar/DeleteSubscriptionAction.jsx # frontend/src/metabase/visualizations/components/LegendItem.jsx # frontend/src/metabase/visualizations/components/PinMap.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #38811 , Milestone 2
Description
This migrates global CSS rules related to buttons to be locally scoped.
How to verify