Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support appending new CSV fields (#39951) #40220

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

crisptrutski
Copy link
Contributor

This is a recreated merge of #39951, with no additional changes.

For some reason the Graphite merge blocker didn't work, and this was prematurely merged into its parent before its auto-merge had triggered.

I'd like to keep the commits separate, so I reverted its parent and created this new PR.

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Mar 18, 2024
@crisptrutski crisptrutski changed the title Publish snowplow events on CSV append success / failure Support appending new CSV fields (#39951) Mar 18, 2024
Copy link
Contributor

@calherries calherries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproving from #39951

Copy link

replay-io bot commented Mar 18, 2024

Status Complete ↗︎
Commit 2a7d46f
Results
⚠️ 4 Flaky
2366 Passed

Copy link
Contributor Author

crisptrutski commented Mar 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @crisptrutski and the rest of your teammates on Graphite Graphite

Base automatically changed from csv-append-snowplow to master March 18, 2024 16:16
@crisptrutski crisptrutski added the no-backport Do not backport this PR to any branch label Mar 18, 2024
@crisptrutski crisptrutski enabled auto-merge (squash) March 18, 2024 17:25
@crisptrutski crisptrutski merged commit a767fd3 into master Mar 18, 2024
115 of 129 checks passed
@crisptrutski crisptrutski deleted the add-fields-remerge branch March 18, 2024 18:21
Copy link

@crisptrutski Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants