Redshfit: sync tables with partial select permission #40421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnkhuat
commented
Mar 21, 2024
| " t.objectname as table," | ||
| ;; interestingly if you have table privilege, has_any_column_privilege is false in redshift. 1) what! | ||
| " pg_catalog.has_table_privilege(current_user, '\"' || t.schemaname || '\"' || '.' || '\"' || t.objectname || '\"', 'SELECT')" | ||
| " OR pg_catalog.has_any_column_privilege(current_user, '\"' || t.schemaname || '\"' || '.' || '\"' || t.objectname || '\"', 'SELECT') as select," |
There was a problem hiding this comment.
has_any_column_privilege return false if you have full select privileges :), we need to do has_table_privilege OR has_any_column_privilege here.
also has_any_column_privilege only exists on select and update.
There was a problem hiding this comment.
this is pretty surprising so let's leave this as a comment, like I've suggested here https://github.com/metabase/metabase/pull/40421/files#r1533731501
|
calherries
added
the
backport
calherries
approved these changes
Mar 21, 2024
| qual-mview-name | ||
| qual-tbl-partial-select-name | ||
| qual-tbl-partial-update-name | ||
| username))))))))) |
There was a problem hiding this comment.
we'll need a newline here
modules/drivers/redshift/test/metabase/driver/redshift_test.clj
Outdated
Show resolved
Hide resolved
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
|
@qnkhuat Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
qnkhuat
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similiar to #40034 but for redshift