Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Often SLO won't be setup on the IdP but we should still delete the session. #40459

Merged
merged 4 commits into from Mar 21, 2024
Merged

Often SLO won't be setup on the IdP but we should still delete the session. #40459

merged 4 commits into from Mar 21, 2024

Conversation

escherize
Copy link
Contributor

@escherize escherize commented Mar 21, 2024 •
edited

Deletes the session, even if SLO is not setup.

@escherize escherize requested a review from dpsutton March 21, 2024 17:14
@escherize escherize requested a review from camsaul as a code owner March 21, 2024 17:14
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Mar 21, 2024
@escherize escherize changed the title Often slo won't be setup, but we should still delete the session Often SLO won't be setup on the IdP but we should still delete the session. Mar 21, 2024
@escherize escherize requested a review from noahmoss March 21, 2024 17:19
@replay-io replay.io
Copy link

replay-io bot commented Mar 21, 2024 •
edited

Status Complete ↗︎
Commit 08694a3
Results
⚠️ 3 Flaky
✅ 2373 Passed

@escherize escherize added the backport Automatically create PR on current release branch on merge label Mar 21, 2024
@escherize escherize enabled auto-merge (squash) March 21, 2024 20:25
@escherize escherize merged commit 5c946b3 into master Mar 21, 2024
108 checks passed
@escherize escherize deleted the sloless-slo-logout branch March 21, 2024 20:38
@github-actions GitHub Actions
Copy link

@escherize Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@escherize
Often SLO won't be setup on the IdP but we should still delete the se…
c8b4b8f 
…ssion. (#40459)

* Often slo won't be setup, but we should still delete the session

* test that we delete the session even when "/handle_slo" is not called

* cleanup test

* take the cookie from the session, not as a parameter
@metabase-bot metabase-bot bot mentioned this pull request Mar 21, 2024
Merged
metabase-bot bot added a commit that referenced this pull request Mar 21, 2024
@metabase-bot @escherize
Often SLO won't be setup on the IdP but we should still delete the se…
0c1892d 
…ssion. (#40459) (#40471)

* Often slo won't be setup, but we should still delete the session

* test that we delete the session even when "/handle_slo" is not called

* cleanup test

* take the cookie from the session, not as a parameter

Co-authored-by: bryan <bryan.maass@gmail.com>
@crisptrutski crisptrutski added this to the 0.49.2 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmoss noahmoss noahmoss approved these changes

@dpsutton dpsutton Awaiting requested review from dpsutton

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@escherize escherize

Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.49.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@escherize @noahmoss @crisptrutski