Convert overflow.module.css to modules
#40498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oisincoveney
changed the title
overflow.module.css to modules
…tion/overflow-module
…tion/overflow-module
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff c772c0a...5bd9bc3.
|
npretto
reviewed
Mar 22, 2024
| @@ -108,7 +109,7 @@ export default function ErrorOverview(props) { | |||
| sorting.column, | |||
| getSortOrder(sorting.isAscending), | |||
| )} | |||
| className="mt2 bounded-overflow-x-scroll" | |||
There was a problem hiding this comment.
Was that a non-existing class? 😕
There was a problem hiding this comment.
Yeah. I searched the whole codebase but this class is mentioned nowhere
|
|
@oisincoveney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
If you are merging into master, please add either a
backportor ano-backportlabel to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details.Closes https://github.com/metabase/metabase/issues/[issue_number]
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist