-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert overflow.module.css
to modules
#40498
Conversation
overflow.module.css
to modules
…tion/overflow-module
…tion/overflow-module
Codenotify: Notifying subscribers in CODENOTIFY files for diff c772c0a...5bd9bc3.
|
@@ -108,7 +109,7 @@ export default function ErrorOverview(props) { | |||
sorting.column, | |||
getSortOrder(sorting.isAscending), | |||
)} | |||
className="mt2 bounded-overflow-x-scroll" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that a non-existing class? 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I searched the whole codebase but this class is mentioned nowhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
@oisincoveney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Important
If you are merging into master, please add either a
backport
or ano-backport
label to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details.Closes https://github.com/metabase/metabase/issues/[issue_number]
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist