Convert cursor.module.css to CSS modules
#40522
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 359a8da...9e06333.
|
|
| CS.inlineBlock, | ||
| CS.full, | ||
| CS.cursorPointer, | ||
| `text-${color}-hover`, |
There was a problem hiding this comment.
This will be hard to find when we will need to migrate such classes
There was a problem hiding this comment.
Thankfully that's the only class name I can find that's dynamically generated. I've seen it a billion times and should be sorted with colors.module.
And, of course as I look at it I didn't sort it in the colors module. I'll do that there
| @@ -1,15 +1,11 @@ | |||
| :global(.cursor-pointer), | |||
| .cursor-pointer, | |||
There was a problem hiding this comment.
Found 2 more places where it is used still:
There was a problem hiding this comment.
Ah, didn't see the second one. I know the e2e test needs to be sorted but I'll do that in a sec
| @@ -267,7 +267,7 @@ function TargetWithSource({ | |||
| </div> | |||
| </div> | |||
| <div | |||
| className="cursor-pointer ml-auto" | |||
| className={cx(CS.cursorPointer, CS.mlAuto)} | |||
There was a problem hiding this comment.
mlAuto needs to be added along .ml-auto
There was a problem hiding this comment.
Ah I am getting caught doing all of these PRs. I'll stack them in the future
oisincoveney
changed the base branch from
master
to
add-identity-obj-proxy-for-css-module-tests
oisincoveney
force-pushed
the
global-css-migration/cursor-module
branch
from
0366e9d
to
9a060d9
Compare
oisincoveney
changed the base branch from
add-identity-obj-proxy-for-css-module-tests
to
master
| onMove={(source, destination) => | ||
| dispatch(Collections.actions.setCollection(source, destination)) | ||
| } | ||
| onMove={async (source, destination) => { |
There was a problem hiding this comment.
These changes are not related to the PR, most likely there were some issues with merges
There was a problem hiding this comment.
Oh what. Ok I'll reset to the last good commit and go from there
oisincoveney
force-pushed
the
global-css-migration/cursor-module
branch
from
15be1ee
to
6cb2621
Compare
|
@oisincoveney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist