Fix unable to migrate to 49 due to v49.00-059 migration #40547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timestamp with time zone by using a fixed list of what to convert. but it turns out some customer instances has a different list. So this PR removed the fixed list and use a query to get a list of all datetime columns.
qnkhuat
added
the
backport
|
piranha
reviewed
Mar 25, 2024
| (map #(update-vals % (comp keyword lower-case-en))) | ||
| (remove (fn [{:keys [table_name]}] | ||
| (or (#{:databasechangelog :databasechangeloglock} table_name) | ||
| (str/starts-with? (name table_name) "v_")))) |
There was a problem hiding this comment.
I'll put a comment there
piranha
approved these changes
Mar 25, 2024
|
Most probably because of different MySQL vendors |
qnkhuat
added a commit
that referenced
this pull request
Mar 25, 2024
* In #37160 we added a migration to convert all datetime columns to timestamp with time zone by using a fixed list of what to convert. but it turns out some customer instances has a different list. So this PR removed the fixed list and use a query to get a list of all datetime columns.
qnkhuat
added a commit
that referenced
this pull request
Mar 25, 2024
) * In #37160 we added a migration to convert all datetime columns to timestamp with time zone by using a fixed list of what to convert. but it turns out some customer instances has a different list. So this PR removed the fixed list and use a query to get a list of all datetime columns. Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40546
In #37160 we added a migration to convert all datetime columns to timestamp with time zone by using a fixed list of what to convert. But it turns out not all instances have the same list, not sure why, could be that liquibase interprets the timestamp columns differently between version/dialect.
This PR removed the fixed list and used a query to get a list of all datetime columns.
Note: I don't think we need to update the checksum because custom migration has the class name, not the implementation. Tested locally.