Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding a filter for a UUID PK column #40777

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix adding a filter for a UUID PK column #40777

merged 3 commits into from
Mar 29, 2024

Conversation

ranquild
Copy link
Contributor

Fixes #40176

@ranquild ranquild requested a review from camsaul as a code owner March 29, 2024 13:28
@ranquild ranquild self-assigned this Mar 29, 2024
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Mar 29, 2024
@ranquild ranquild requested review from a team March 29, 2024 13:29
@piranha
Copy link
Contributor

piranha commented Mar 29, 2024

The change is fine, but the title does not reflect it - since UUID filtering is going to be broken anyways. :)

@replay-io replay.io
Copy link

replay-io bot commented Mar 29, 2024 •
edited

Status Complete ↗︎
Commit c663b18
Results
⚠️ 3 Flaky
✅ 2387 Passed

@ranquild ranquild changed the title Fix filtering on UUID PK columns Fix adding a filter for a UUID PK column Mar 29, 2024
@ranquild
Copy link
Contributor Author

@piranha slightly changed the title

piranha
piranha approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@piranha piranha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better when frontend doesn't break 👍

@ranquild ranquild enabled auto-merge (squash) March 29, 2024 13:52
@ranquild ranquild merged commit 97ba53d into master Mar 29, 2024
105 checks passed
@ranquild ranquild deleted the 40176-fix-filtering-uuid branch March 29, 2024 16:31
@github-actions GitHub Actions
Copy link

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
@ranquild
Fix adding a filter for a UUID PK column (#40777)
e86b561
@metabase-bot metabase-bot bot mentioned this pull request Mar 29, 2024
Merged
metabase-bot bot added a commit that referenced this pull request Mar 29, 2024
@metabase-bot @ranquild
Fix adding a filter for a UUID PK column (#40777) (#40820)
d61ee93 
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@qnkhuat qnkhuat mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piranha piranha piranha approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@ranquild ranquild

Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering Issue on UUID Column in Version 0.49.0
2 participants
@ranquild @piranha