do not print stacktrace when client closes connection too early #40834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piranha
added
the
backport
|
tsmacdonald
reviewed
Apr 3, 2024
Co-authored-by: Tim Macdonald <tim@metabase.com>
|
@piranha Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our frontend can close connection too early, for example when you change any of parameters. This is most obvious in #36775, but any long-running connection could be interrupted early. We have no way to understand that connection is closed apart from just catching an exception and dealing with it.
Also not like we can do much with it... This error could be handled in
metabase.async.streaming-response/delay-output-stream, but it feels like users of that proxy deserve to know that connection was closed.