You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-ray code has a check that should rerun queries when parameter values changes. Apparently, the first time it's triggered, it receives two maps: one is just empty ({}), and another has all the parameter values set to null. Even though they both basically mean "dashboard filters don't have values set", underscore's isEqual treats them as different, and that triggers extra query reruns.
This PR is rather a band-aid, we should invest some time into unifying this logic with regular and public/embedded dashboards that don't have this issue in the first place
How to verify
Open "Browse data", pick any table and x-ray it (click the bolt icon)
Ensure there're no canceled /api/dataset requests in the Network tab
The reason will be displayed to describe this comment to others. Learn more.
I think having a spec for this can be handy to avoid reintroducing the issue. Also, since it is a quick fix, can you please create a tech debt issue to remove the unnecessary initial render with an empty object?
I think having a spec for this can be handy to avoid reintroducing the issue
I'm afraid an E2E test here would be very flaky and unreliable. The number of redundant requests is different every time, even on a local machine with no network latency
Also, since it is a quick fix, can you please create a tech debt issue to remove the unnecessary initial render with an empty object?
I think ideally we should migrate x-rays to the same dashboard fetching logic as other kinds of dashboard (mainly via Dashboard.tsx component for now). WDYT?
I think ideally we should migrate x-rays to the same dashboard fetching logic as other kinds of dashboard (mainly via Dashboard.tsx component for now). WDYT?
* Fix parameter values comparison in x-rays
* Skip rerun when `parameterValues` are not initialized
* Remove not used code
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
* Fix parameter values comparison in x-rays
* Skip rerun when `parameterValues` are not initialized
* Remove not used code
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
backportAutomatically create PR on current release branch on merge.Team/DashVizDashboard and Viz team
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kulyk
added
backport
Closes #36775
X-ray code has a check that should rerun queries when parameter values changes. Apparently, the first time it's triggered, it receives two maps: one is just empty (
{}), and another has all the parameter values set tonull. Even though they both basically mean "dashboard filters don't have values set", underscore'sisEqualtreats them as different, and that triggers extra query reruns.This PR is rather a band-aid, we should invest some time into unifying this logic with regular and public/embedded dashboards that don't have this issue in the first place
How to verify
/api/datasetrequests in the Network tab