Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "Fix row id mapping in object detail modal displaying" #40951

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Apr 3, 2024

* Map row id on object detail id

* Add a fallback

* Add e2e test

* Add a limit

* Provide a fix for #34070

* Simplify test
@metabase-bot metabase-bot bot added the was-backported apply this to PRs that are themselves backports label Apr 3, 2024
@metabase-bot metabase-bot bot enabled auto-merge (squash) April 3, 2024 12:33
@metabase-bot metabase-bot bot added the visual Run Percy visual testing label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff cf0a84d...d40dc5e.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.jsx

Copy link

replay-io bot commented Apr 3, 2024

Status Complete ↗︎
Commit d40dc5e
Results
⚠️ 2 Flaky
2359 Passed

@metabase-bot metabase-bot bot merged commit 9d8201f into release-x.49.x Apr 3, 2024
112 of 113 checks passed
@metabase-bot metabase-bot bot deleted the backport-54ed754436d54da5047d8a62ca20e6f8a5968ed1 branch April 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual Run Percy visual testing was-backported apply this to PRs that are themselves backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant