Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 backported "[QP] Correctly find joined fields in the previous stage" #40987

Merged
merged 2 commits into from
Apr 8, 2024
Merged

🤖 backported "[QP] Correctly find joined fields in the previous stage" #40987

merged 2 commits into from
Apr 8, 2024

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Apr 3, 2024

#40933

Important

Manual conflict resolution is required.
Checkout the branch and run ./backport.sh script. Force push your changes after cherry-picking.

@metabase-bot metabase-bot bot added the was-backported apply this to PRs that are themselves backports label Apr 3, 2024
@darksciencebase darksciencebase added the .Team/QueryProcessor :hammer_and_wrench: label Apr 4, 2024
@bshepherdson bshepherdson force-pushed the backport-cb506458ee63cc7ea63454fba14aeb204a5311a0 branch from a4459b3 to fb47d88 Compare April 4, 2024 15:53
@metabase-bot metabase-bot bot requested a review from camsaul as a code owner April 4, 2024 15:53
@bshepherdson bshepherdson requested a review from a team April 4, 2024 15:53
@bshepherdson bshepherdson added this to the 0.49.4 milestone Apr 4, 2024
@bshepherdson bshepherdson enabled auto-merge (squash) April 4, 2024 15:54
@replay-io replay.io
Copy link

replay-io bot commented Apr 4, 2024 •
edited

Status In Progress ↗︎ 51 / 52
Commit b853051
Results
⚠️ 4 Flaky
✅ 2360 Passed

@bshepherdson
backport "[QP] Correctly find joined fields in the previous stage (#4…
00dcb3a 
…0933)"

This logic was trying to match `[name join-alias]` pairs previously, but
that won't work since the later stage field doesn't have a `:join-alias`
on it. This falls back to matching on only the ID or name, but only if
it's unambiguous.

See #40252.
@bshepherdson bshepherdson force-pushed the backport-cb506458ee63cc7ea63454fba14aeb204a5311a0 branch from fb47d88 to 00dcb3a Compare April 5, 2024 14:18
@bshepherdson bshepherdson merged commit 47719fa into release-x.49.x Apr 8, 2024
106 checks passed
@bshepherdson bshepherdson deleted the backport-cb506458ee63cc7ea63454fba14aeb204a5311a0 branch April 8, 2024 13:26
@WiNloSt WiNloSt removed this from the 0.49.4 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsaul camsaul camsaul approved these changes

Assignees

@bshepherdson bshepherdson

Labels
.Team/QueryProcessor :hammer_and_wrench: was-backported apply this to PRs that are themselves backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camsaul @bshepherdson @WiNloSt @darksciencebase