asynchronously load libraries for png and pdf exports #41036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metabase-bot
bot
added
.Team/DashViz
uladzimirdev
approved these changes
Apr 4, 2024
| @@ -17,6 +14,7 @@ export const saveDashboardPdf = async ( | |||
| return; | |||
| } | |||
|
|
|||
| const { default: html2canvas } = await import("html2canvas"); | |||
There was a problem hiding this comment.
nit: I'd keep import on the top level, but with import(), so the new chunk will be created automatically and at the same time user will not need to wait for chunk to be downloaded after a click to "download"
actually if you already wait for downloading some big file, chunk loading is not a problem, so please ignore my comment
alxnddr
added
the
backport
|
|
@alxnddr Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic #41032
Description
Reduces the size of the vendor bundle by extracting heavy libraries used for pdf and png exports which should not block the initial app loading.
Before
After
How to verify
vendorchunk sizeDemo
Screen.Recording.2024-04-04.at.11.09.18.AM.mov