serialize result_metadata for any card #41131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this for every card, since when a normal question depends on a native question - their result_metadata won't be updated when opening a dashboard, which leads to front-end not understanding how to connect the parameters, and errors during queries.
piranha
added
backport
|
crisptrutski
reviewed
Apr 8, 2024
tsmacdonald
approved these changes
Apr 8, 2024
crisptrutski
reviewed
Apr 8, 2024
|
@piranha Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
|
@metabase-bot backport release-x.48.x |
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
changed the title
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
added a commit
that referenced
this pull request
Apr 9, 2024
piranha
added a commit
that referenced
this pull request
Apr 11, 2024
piranha
added a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for every card, since when a normal question depends on a native question - their result_metadata won't be updated when opening a dashboard, which leads to front-end not understanding how to connect the parameters, and errors during queries.