Add Schedule strategy to Admin > Performance #41230
Merged
+1,044
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
force-pushed
the
perf/mqd-seconds
branch
from
b015df3
to
e6a34c3
Compare
Schedule component can save by converting to and from cron in Admin / Performance
|
rafpaf
commented
Apr 12, 2024
frontend/src/metabase/admin/performance/components/StrategyForm.tsx
Outdated
Show resolved
Hide resolved
rafpaf
commented
Apr 12, 2024
frontend/src/metabase/admin/performance/components/StrategyForm.tsx
Outdated
Show resolved
Hide resolved
rafpaf
commented
Apr 12, 2024
sloansparger
approved these changes
Apr 12, 2024
rafpaf
commented
Apr 12, 2024
crisptrutski
pushed a commit
that referenced
this pull request
Apr 15, 2024
Adds a Schedule strategy to the Admin / Performance page  [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516) As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important. Tests for the Schedule component will be added in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41424
Adds a Schedule strategy to the Admin / Performance page
Loom
As discussed with @luizarakaki, rather than modify the legacy
SchedulePickerto work with this use case, I made a new version of it - aSchedulecomponent - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important.Tests for the Schedule component will be added in a follow-up PR.