Add most used functions to suggestions when they open #41267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
romeovs
force-pushed
the
41237-add-most-used-functions
branch
2 times, most recently
from
4043029
to
353d366
Compare
romeovs
force-pushed
the
41237-add-most-used-functions
branch
3 times, most recently
from
5335797
to
3c6be77
Compare
romeovs
force-pushed
the
41237-add-most-used-functions
branch
3 times, most recently
from
84dc86b
to
1c2c4ba
Compare
romeovs
force-pushed
the
41237-add-most-used-functions
branch
from
1c2c4ba
to
87837ce
Compare
romeovs
commented
Apr 12, 2024
| helpText?: HelpText; | ||
| }; | ||
|
|
||
| function suggestWithFooters( |
There was a problem hiding this comment.
Adding the footer seemed misplaced in metabase-lib/v1/expressions, so I decided to do it here.
I wanted to keep the footers in the list of suggestions to avoid having to jump trough hoops to add the footer to the up/down arrow flow.
romeovs
commented
Apr 12, 2024
...query_builder/components/expressions/ExpressionEditorTextfield/ExpressionEditorTextfield.tsx
Show resolved
Hide resolved
Fix e2e tests
romeovs
force-pushed
the
41237-add-most-used-functions
branch
from
b98d921
to
1f356ad
Compare
kamilmielnik
approved these changes
Apr 16, 2024
| }) { | ||
| function handleMouseDownCapture(evt: MouseEvent) { | ||
| // prevent the dropdown from closing | ||
| evt.preventDefault(); |
There was a problem hiding this comment.
Still unresolved. I don't think it should prevent this PR from being merged, but let's keep it somewhere in the backlog as a P3 bug.
| type SuggestArgs = { | ||
| export const GROUPS = { | ||
| popularExpressions: { | ||
| displayName: t`Most used functions`, |
There was a problem hiding this comment.
Clicking the group title causes the popover to disappear. Not critical, but if it's easy to fix we should do it.
2024-04-16.15-21-40.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41237
Description
Adds the most used functions to the list of suggestions when the expression editor opens.
To accomplish this, this PR:
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Checklist
Note
This PR is a follow up of #41236, so it contains changes from it.