Add INFO log for each table being fingerprinted #41365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calherries
added
the
backport
crisptrutski
approved these changes
Apr 12, 2024
Comment on lines
+198
to
+199
| (do | ||
| (log/infof "Fingerprinting %s fields in table %s" (count fields) (sync-util/name-for-logging table)) |
There was a problem hiding this comment.
Stylistically I'd prefer putting this as a _ binding at the start of the let block to avoid so many levels of nesting.
There was a problem hiding this comment.
Also a smaller diff 😄
There was a problem hiding this comment.
mmm yeah that could look nicer. i'll try it next time
|
@calherries Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds INFO-level logs per table being fingerprinted. These logs will help debug performance issues with fingerprinting, because you can correlate issues with specific tables being fingerprinted.
If you add
<Logger name="metabase.sync.analyze.fingerprint" level="INFO"/>to the log4j2.xml file, you'll get these additional lines in your logs when syncing a table for the first time: