Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Integration branch for design review #41438

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Apr 15, 2024

Integration branch for #39153

piranha and others added 30 commits April 5, 2024 17:07
New endpoint accepts entity and entity ids in form of `database=1&dashboard=2&question=3`. If you don't supply
`&include=overrides`, then it tries to find configs directly referencing supplied entities and updates their
`invalidated_at`. If you supply `&include=overrides`, all the referenced cards are
updated (`report_card.cache_invalidated_at`).

Cache strategies then select the maximum `invalidated_at` in their logic. EE-only.

resolves #40548
Implement new look and placement of Invalidate now button, and show error message in a toast

Refactor

Set height of form buttons to 40px

Improve a11y of tooltip

Use CSS flex, not position:sticky, for form buttons
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Apr 15, 2024
Copy link

github-actions bot commented Apr 15, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff b829cb7...9fdce63.

Notify File(s)
@kdoh frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.styled.tsx

Copy link

replay-io bot commented Apr 15, 2024

Status Complete ↗︎
Commit 9fdce63
Results
5 Failed
⚠️ 20 Flaky
2383 Passed

@rafpaf rafpaf changed the title Perf/integration [Cache] Integration branch for design review Apr 16, 2024
@rafpaf rafpaf marked this pull request as draft April 16, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants