Links to metabase URLs should open in the same window in link cards #41508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heypoom
added
the
backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff c288e4d...1374c28.
|
|
WiNloSt
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
This works great 👍
Re:
An open question is how should we handle invalid relative links in external link cards.
As they're already broken, I don't think we have to do anything. The only thing we change here is to open them in the same tab rather than on the new page, but the behavior of the open pages remains the same.
I think users would likely be able to spot broken links and fix them themselves pretty easily.
|
@heypoom Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…41508) * external link cards should apply the correct target attribute * add unit tests for absolute and relative question links in link cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #30891
Description
External link cards currently always opens in new tabs. When clicking on a link to metabase urls, such as
https://example.com/question/1-some-question, it opens a new tab instead of opening in the same window. This makes the URL break out of embedding as well.This PR makes it so links with the same origin or same as the site url open in the same window.
Caveat
This also causes all relative links to open in the same tab. This would make relative links to questions and dashboards open correctly, but invalid relative links such as
example.com,www.example.com,foobarwill remain broken. An open question is how should we handle invalid relative links in external link cards.How to verify
https://localhost:3000/dashboard/1-exampledashboard/1-exampleChecklist