Add curate permissions for "All Users" for example collection #41512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calherries
commented
Apr 17, 2024
Comment on lines
+1168
to
+1170
| example-dashboard-id 1 | ||
| example-collection-id 1 | ||
| expected-sample-db-id 1 |
There was a problem hiding this comment.
I just re-ordered these to be at the top, and added example-collection-id
calherries
commented
Apr 17, 2024
| _ (t2/query {:insert-into :metabase_database :values dbs}) | ||
| db-ids (set (map :id (t2/query {:select :id :from :metabase_database}))) | ||
| example-dashboard-id 1 | ||
| expected-db-ids #{example-dashboard-id}] |
There was a problem hiding this comment.
This was a logical bug to use example-dashboard-id but I got away with it because it is the same as the expected DB ID (both are 1).
calherries
added
backport
|
calherries
force-pushed
the
all-users-curate-example-collection
branch
from
62778f9
to
95f4889
Compare
|
@calherries Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "curate" permissions for "All Users" for example collection added in #40753. Previously only Admins had access. I decided to implement it in Clojure and not by adding more data to
resources/sample-content.edn, because if we want to export another collection in the future the separation of content and permissions will make that process simpler.Before:
After:
