Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible user items in search filters #41604

Merged
merged 1 commit into from Apr 18, 2024
Merged

Conversation

iethree
Copy link
Contributor

@iethree iethree commented Apr 18, 2024

issue report: https://metaboat.slack.com/archives/C064EB1UE5P/p1713460122043189

Description

200w

On large lists of users in search filters, we were shrinking the user list items to the point of being invisible'

Before After
Screen Shot 2024-04-18 at 12 58 32 PM Screen Shot 2024-04-18 at 12 57 46 PM

@iethree iethree requested a review from a team April 18, 2024 19:02
@iethree iethree self-assigned this Apr 18, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Apr 18, 2024
@iethree iethree added the backport Automatically create PR on current release branch on merge label Apr 18, 2024
@iethree iethree changed the title Fix super shrunk user items Fix invisible user items in search filters Apr 18, 2024
Copy link

replay-io bot commented Apr 18, 2024

Status Complete ↗︎
Commit 3b04af3
Results
⚠️ 14 Flaky
2396 Passed

@iethree iethree enabled auto-merge (squash) April 18, 2024 19:15
@iethree iethree merged commit 427fbc1 into master Apr 18, 2024
119 of 138 checks passed
@iethree iethree deleted the fix-empty-search-user-list branch April 18, 2024 20:20
Copy link

@iethree Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@iethree iethree modified the milestones: 0.47.14, 0.49.7 Apr 18, 2024
metabase-bot bot added a commit that referenced this pull request Apr 18, 2024
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants