Add table of models to the "Browse models" page #41954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
e2ebff4
to
71854f7
Compare
This was referenced Apr 29, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 29, 2024
Closed
|
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
71854f7
to
f61d114
Compare
npfitz
previously requested changes
Apr 30, 2024
frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarView.tsx
Outdated
Show resolved
Hide resolved
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
f61d114
to
53caf2c
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3d12656...0fcdcf0. No notifications. |
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
376770b
to
d76ef86
Compare
rafpaf
force-pushed
the
browse/nav
branch
3 times, most recently
from
27bdefe
to
5463c7e
Compare
rafpaf
force-pushed
the
port-collapse-to-ts
branch
from
49db631
to
671f83f
Compare
rafpaf
force-pushed
the
port-collapse-to-ts
branch
from
671f83f
to
35b590c
Compare
rafpaf
force-pushed
the
browse/nav
branch
2 times, most recently
from
05d8761
to
b2c90a3
Compare
iethree
approved these changes
May 8, 2024
Comment on lines
86
to
87
| {/* Type */} | ||
| <Columns.Type.Cell icon={icon} /> |
There was a problem hiding this comment.
very small nit but this column has cursor: pointer, but clicking it doesn't do anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41603