-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port metric v1 e2e tests #42125
Port metric v1 e2e tests #42125
Conversation
|
@@ -845,6 +845,79 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => { | |||
.contains("[Revenue]"); | |||
}); | |||
}); | |||
|
|||
it("should be possible to sort by metric (metabase#8283)", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scavenged from the admin metrics tests.
cy.findByText("Created At is Jan 1–31, 2024").should("be.visible"); | ||
}); | ||
// FIXME metrics v2 -- check that the values in column Total are above 150 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to do this best. Ideally, we would like to check that the filter is still in effect, but I don't think it should be listed as it's part of the metric which is still the source.
// FIXME metrics v2 | ||
// eslint-disable-next-line jest/no-disabled-tests | ||
it.skip("should return fields from the model question's virtual card table, as though it is already nested", () => { | ||
it("should return fields from the model question's virtual card table, as though it is already nested", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see how this is related to metrics, so I think it should pass.
// FIXME metrics v2 | ||
// eslint-disable-next-line jest/no-disabled-tests | ||
it.skip("does not show custom warning modal when saving new model", async () => { | ||
it("does not show custom warning modal when saving new model", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see how this is related to metrics, so I think it should pass.
No description provided.