Window functions should use all breakouts except first for partitioning #42131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
metamben
approved these changes
May 2, 2024
src/metabase/query_processor/middleware/cumulative_aggregations.clj
Outdated
Show resolved
Hide resolved
|
@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented #2862 in #41340 earlier in the 50 cycle I had it partition by all breakouts except the first, and order by the last breakout; this behavior was confusing and product asked me to change it to order by the first breakout and partition by all the other ones. See this Slack thread https://metaboat.slack.com/archives/C05MPF0TM3L/p1714084449574689
Since this hasn't gone out yet it doesn't hurt to change the behavior of this stuff now.
Fixes #42003