Forbid using styles prop for Mantine components #42213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f418e68...8f2f324.
|
|
iethree
requested changes
May 3, 2024
There was a problem hiding this comment.
I think you've identified an important issue here, but i think it probably needs a more subtle solution than simply banning styles props. Adding variants every time we need internal changes to a component is no good either. I fear that this approach will just leave us with lots of // eslint-disable comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In several cases I faced overriding default styles in our
metabase/uicomponents could be avoided (by using a variant of the same component or using another component), one of the simplest ways to override styles is to usestylesprop, so let's forbid its usage by default