-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs - env var 49 #42228
docs - env var 49 #42228
Conversation
|
||
See also [`MB_UNAGGREGATED_QUERY_ROW_LIMIT`](#mb_unaggregated_query_row_limit). | ||
Maximum number of rows to return for aggregated queries via the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the extra context from the previous version
|
||
Sets the maximum number of days Metabase preserves rows for the following application database tables: | ||
Maximum number of rows to render in an alert or subscription image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I think the extra context from the original file is important
|
||
Timeout in milliseconds for connecting to databases, both Metabase application database and data connections. In case you're connecting via an SSH tunnel and run into a timeout, you might consider increasing this value as the connections via tunnels have more overhead than connections without. | ||
Consider metabase.driver/can-connect? / can-connect-with-details? to have failed if they were not able to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description isn't helpful to end user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, but I think we should do a full audit of descriptions. I foudn some variables that have better descriptions in the original file (I didn't comment on all of them, just the first few)
|
Closing this in favor of #43150. |
Adds auto-generated env var docs.