Add can_write to cards/dashboards in Search
#42276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnswanson
added
the
backport
|
escherize
reviewed
May 6, 2024
src/metabase/api/search.clj
Outdated
| @@ -512,6 +517,7 @@ | |||
| total-results (cond->> (scoring/top-results reducible-results search.config/max-filtered-results xf) | |||
| true hydrate-user-metadata | |||
| (:model-ancestors? search-ctx) (add-dataset-collection-hierarchy) | |||
| true (map add-can-write) | |||
There was a problem hiding this comment.
Do you think we can move this map operation into the xf above?
There was a problem hiding this comment.
Good idea, done!
escherize
approved these changes
May 6, 2024
johnswanson
added a commit
that referenced
this pull request
May 16, 2024
johnswanson
added a commit
that referenced
this pull request
May 16, 2024
johnswanson
added a commit
that referenced
this pull request
May 16, 2024
johnswanson
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.