Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct icon for the extract column shortcut #42415

Merged
merged 1 commit into from May 9, 2024

Conversation

romeovs
Copy link
Contributor

@romeovs romeovs commented May 8, 2024

Fixes a bug where the incorrect icon was displaying for the extract column shortcut.

  1. New question -> Sample data -> Orders
  2. Add new column
  3. The suggestion dropdown should show the correct icon for extract column
Screenshot 2024-05-08 at 20 05 26

@romeovs romeovs added the no-backport Do not backport this PR to any branch label May 8, 2024
@romeovs romeovs requested a review from a team May 8, 2024 18:06
@romeovs romeovs self-assigned this May 8, 2024
Copy link

replay-io bot commented May 8, 2024

Status Complete ↗︎
Commit 1db88de
Results
⚠️ 11 Flaky
2470 Passed

@romeovs romeovs merged commit 3a33bba into master May 9, 2024
126 of 142 checks passed
@romeovs romeovs deleted the fix-extract-icon-in-expression-editor branch May 9, 2024 08:54
Copy link

github-actions bot commented May 9, 2024

@romeovs Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants