Metrics E2E tests - part 2 #42427
Merged
Metrics E2E tests - part 2 #42427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
commented
May 8, 2024
| @@ -67,7 +68,7 @@ export function JoinTablePicker({ | |||
| databaseId: DatabaseId, | |||
| ) => { | |||
| await dispatch(loadMetadataForTable(databaseId, tableId)); | |||
| onChange?.(Lib.tableOrCardMetadata(queryRef.current, tableId)); | |||
| onChangeRef.current?.(Lib.tableOrCardMetadata(queryRef.current, tableId)); | |||
There was a problem hiding this comment.
For some reason this change got lost in the integration branch
There was a problem hiding this comment.
We need this in master too.
I have it coming in the data-picker feature branch but it's still few steps away from being ready.
ranquild
commented
May 8, 2024
| display: "scalar", | ||
| }; | ||
|
|
||
| describe("scenarios > metrics", () => { |
There was a problem hiding this comment.
git isn't smart enough to understand it's the same file. What's changed:
- Helpers got options and they started to work in multiple stages
- Some multi-stage tests were added
|
kamilmielnik
approved these changes
May 9, 2024
| }); | ||
| popover().button("Done").click(); | ||
| saveMetric(); | ||
| runQuery(); |
There was a problem hiding this comment.
Missing assertion. We can leave a "FIXME" comment like in the previous skipped test.
| @@ -67,7 +68,7 @@ export function JoinTablePicker({ | |||
| databaseId: DatabaseId, | |||
| ) => { | |||
| await dispatch(loadMetadataForTable(databaseId, tableId)); | |||
| onChange?.(Lib.tableOrCardMetadata(queryRef.current, tableId)); | |||
| onChangeRef.current?.(Lib.tableOrCardMetadata(queryRef.current, tableId)); | |||
There was a problem hiding this comment.
We need this in master too.
I have it coming in the data-picker feature branch but it's still few steps away from being ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests and new bugs found.