Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsify descriptions properly in Browse models #42456

Merged
merged 2 commits into from May 13, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 9, 2024

We accomplish this by markdownifying the tooltip content but not the description in the <td>. Dawei and Maz approved this approach

image.png

Copy link
Contributor Author

rafpaf commented May 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 9, 2024
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label May 9, 2024 — with Graphite App
@rafpaf rafpaf requested a review from a team May 9, 2024 14:03
@rafpaf rafpaf marked this pull request as ready for review May 9, 2024 14:04
Copy link

replay-io bot commented May 9, 2024

Status Complete ↗︎
Commit 7689e91
Results
⚠️ 5 Flaky
2503 Passed

Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafpaf rafpaf enabled auto-merge (squash) May 9, 2024 14:25
@rafpaf rafpaf force-pushed the browse/ellipsified-descriptions branch 3 times, most recently from 70af81a to b735001 Compare May 10, 2024 23:35
@rafpaf rafpaf force-pushed the browse/ellipsified-descriptions branch from b735001 to d675683 Compare May 13, 2024 18:03
@rafpaf rafpaf merged commit cc0a423 into master May 13, 2024
111 checks passed
@rafpaf rafpaf deleted the browse/ellipsified-descriptions branch May 13, 2024 20:47
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.50 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants