Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify how optional SQL vars work #42490

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

alexyarosh
Copy link
Contributor

Some users think that they just need to surround the variable with [[ ]] to make a variable optional. You can actually put brackets around anything, but you need to make sure that SQL actually executes without [[ ]].

(Could probably use some more wordsmithing)

@alexyarosh alexyarosh added Type:Documentation backport Automatically create PR on current release branch on merge labels May 9, 2024
@alexyarosh alexyarosh self-assigned this May 9, 2024
docs/questions/native-editor/sql-parameters.md Outdated Show resolved Hide resolved
docs/questions/native-editor/sql-parameters.md Outdated Show resolved Hide resolved
docs/questions/native-editor/sql-parameters.md Outdated Show resolved Hide resolved
docs/questions/native-editor/sql-parameters.md Outdated Show resolved Hide resolved
docs/questions/native-editor/sql-parameters.md Outdated Show resolved Hide resolved
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
@alexyarosh alexyarosh enabled auto-merge (squash) May 10, 2024 16:05
@alexyarosh alexyarosh merged commit 3ef530d into master May 10, 2024
111 checks passed
@alexyarosh alexyarosh deleted the docs-ay-valid-sql branch May 10, 2024 16:06
Copy link

@alexyarosh Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request May 10, 2024
* how optional clauses work

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
metabase-bot bot added a commit that referenced this pull request May 10, 2024
* how optional clauses work

* Apply suggestions from code review



---------

Co-authored-by: Alex Yarosh <alexandra@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
uladzimirdev pushed a commit that referenced this pull request May 11, 2024
* how optional clauses work

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
@sloansparger sloansparger added this to the 0.49.10 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge Type:Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants