-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - diagnose-expression
throws when Offset
is nested
#42497
Conversation
|
enterCustomColumnDetails({ formula, name }); | ||
|
||
cy.on("uncaught:exception", error => { | ||
expect(error.message.includes("Error normalizing")).not.to.be.true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what kind of error do we expect? is there any other way to verify we don't have normalization error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what kind of error do we expect?
We expect no error.
cy.on
will however catch all the other errors from console, e.g. warnings about missing props coming from React, etc.
is there any other way to verify we don't have normalization error?
We could wrap Lib.diagnoseExpression
call in diagnostics.ts
in a try
/catch
block and then the error would be shown to the user. I'm not sure why we haven't done that originally.
@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
* Fix offset not working in case * Make offset function return any * Add a repro for #42377 * Fix order of adjustments * Revert unrelated changes * Remove commented code * Revert unrelated changes
Fixes #42377
Description
Switches the order of appliance of
adjustOffset
andadjustCase
.How to verify
New e2e test passes.