Put bulk actions above popovers in collections #42512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Don't backport" took an action on this PR • (05/10/24)1 reviewer was added and 1 label was added to this PR based on Raphael Krut-Landau's automation. |
|
iethree
approved these changes
May 10, 2024
|
@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
|
lol, I'm so sorry for tagging you, @container! I'm of course referring to https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_containment/Container_queries |
uladzimirdev
pushed a commit
that referenced
this pull request
May 11, 2024
* q * Restore margin-left adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the collection table now inside a
@container, popovers were being created above the bulk actions toast (z-axis-wise). This branch fixes this by changing which element serves as the container (we'll useCollectionTable, notCollectionRoot- both are equally good), and moving the bulk actions toast just outside this container.Now the toast appears above popovers:
This branch also restores the margin-left adjustment that is needed to correct the position of the bulk actions toast when the sidebar is open. This adjustment was recently removed because the @container query fixes this problem, but now that the toast is not inside the @container, we need to restore that solution.