Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to GoogleAnalytics tracking #42556

Merged
merged 1 commit into from
May 13, 2024

Conversation

nemanjaglumac
Copy link
Member

This PR removes the code related to GoogleAnalytics tracking that's left after #42515.

It DOES NOT remove the GA driver.
More context: #32096 (comment)

@nemanjaglumac nemanjaglumac added no-backport Do not backport this PR to any branch 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something labels May 13, 2024
@nemanjaglumac nemanjaglumac requested review from a team May 13, 2024 09:07
@nemanjaglumac nemanjaglumac self-assigned this May 13, 2024
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff e8dc5ec...fe551ff.

Notify File(s)
@alxnddr frontend/src/metabase/lib/analytics.js
@ranquild frontend/src/metabase/lib/analytics.js

Copy link

replay-io bot commented May 13, 2024

Status In Progress ↗︎ 51 / 52
Commit fe551ff
Results
⚠️ 3 Flaky
2496 Passed

@nemanjaglumac nemanjaglumac merged commit 38d540a into master May 13, 2024
132 of 145 checks passed
@nemanjaglumac nemanjaglumac deleted the remove-ga-tracking-code branch May 13, 2024 10:01
Copy link

@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants