Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require an explicit knob to allow uploading ReplayIO recordings #42649

Merged
merged 5 commits into from
May 15, 2024
Merged

Require an explicit knob to allow uploading ReplayIO recordings #42649

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
499d4ff
Explicitly decide whether to upload or not
nemanjaglumac May 15, 2024
5409d0a
Upload in the main e2e workflow, but skip uploading in stress-test wo…
nemanjaglumac May 15, 2024
1a81844
Do not record runs in the stress-test workflow
nemanjaglumac May 15, 2024
bcf4bac
Add Replay API key
nemanjaglumac May 15, 2024
4199789
Omit env var from the stress-test workflow
nemanjaglumac May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/e2e-stress-test-flake-fix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ jobs:
QA_DB_ENABLED: true
CYPRESS_QA_DB_MONGO: true
CYPRESS_REPLAYIO_ENABLED: 1
CYPRESS_REPLAYIO_ENABLE_UPLOAD: 0
RECORD_REPLAY_NO_RECORD: 1 # No need to record since we're not uploading anything
REPLAY_API_KEY: ${{ secrets.REPLAY_IO_TOKEN }}
CYPRESS_ALL_FEATURES_TOKEN: ${{ secrets.ENTERPRISE_TOKEN }}
CYPRESS_NO_FEATURES_TOKEN: ${{ secrets.E2E_STARTER_TOKEN }}
MB_SNOWPLOW_AVAILABLE: true
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ jobs:
MB_SNOWPLOW_AVAILABLE: true
MB_SNOWPLOW_URL: "http://localhost:9090" # Snowplow micro
CYPRESS_REPLAYIO_ENABLED: 1
CYPRESS_REPLAYIO_ENABLE_UPLOAD: 1
RECORD_REPLAY_METADATA_FILE: /tmp/replay-metadata.json
RECORD_REPLAY_METADATA_TEST_RUN_ID: ${{ github.run_id }}
REPLAY_API_KEY: ${{ secrets.REPLAY_IO_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion e2e/support/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const sourceVersion = process.env["CROSS_VERSION_SOURCE"];
const targetVersion = process.env["CROSS_VERSION_TARGET"];

const runWithReplay = process.env["CYPRESS_REPLAYIO_ENABLED"];
const uploadReplayRecordings = process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing CYPRESS_REPLAYIO_ENABLE_UPLOAD: 0 from the other file and combining it with this change:

Suggested change
const uploadReplayRecordings = process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"];
const uploadReplayRecordings = !!process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"];


const feHealthcheckEnabled = process.env["CYPRESS_FE_HEALTHCHECK"] === "true";

Expand All @@ -40,7 +41,7 @@ const defaultConfig = {
if (runWithReplay) {
on = replay.wrapOn(on);
replay.default(on, config, {
upload: true,
upload: uploadReplayRecordings,
apiKey: process.env.REPLAY_API_KEY,
filter: r => {
const hasCrashed = r.status === "crashed";
Expand Down
Loading