Correct type for report_card.collection_preview
#42919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnswanson
force-pushed
the
jds/fix-mariadb-boolean
branch
2 times, most recently
from
a200b1b
to
22a956b
Compare
|
noahmoss
approved these changes
May 20, 2024
In v49, we converted all boolean types to `bit(1)` on mysql/mariadb. It looks like we missed this one, so when you `GET` a card it has `"collection_preview": 1`. Then we get an error when trying to save, because `collection_preview` should be a boolean. I verified that after this migration, `GET`ting a card results in a boolean `"collection_preview"`.
johnswanson
force-pushed
the
jds/fix-mariadb-boolean
branch
from
22a956b
to
78ff5d6
Compare
This was referenced May 20, 2024
|
@johnswanson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v49, we converted all boolean types to
bit(1)on mysql/mariadb. It looks like we missed this one, so when youGETa card it has"collection_preview": 1. Then we get an error when trying to save, becausecollection_previewshould be a boolean.I verified that after this migration,
GETting a card results in a boolean"collection_preview".Fixes #40600