Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report_card.collection_preview in v49 #42950

Merged
merged 1 commit into from
May 21, 2024

Commits on May 21, 2024

  1. Fix report_card.collection_preview in v49

    This is a bit painful. I merged this change, but realized we need to
    backport the fix to v49. However:
    
    - we don't want to have two versions of the migration (one with a v49
    id, one with a v50 id) because then if someone upgrades to 50, then
    downgrades to 49, the `rollback` will run and change the type back,
    leading to a bug.
    
    - we don't want to push a v51 changeSet ID to v49 or v50, because we
    give the user a helpful notice when their database needs a downgrade.
    We do this by checking for the latest *executed* migration in the
    database and comparing it to the latest migration that Liquibase knows
    about, and making sure the executed isn't bigger than the known (e.g.
    you can't have executed a v51 migration if it isn't in the local
    migration yaml). That would all work fine, except that then we want to
    tell you how to downgrade your database, and we use the latest-executed
    version for that. So if, for example, someone upgraded from 48 to 49 and
    got a v51 changeset, then downgraded back to 48, they would get an error
    telling them to run the *v51* jar to roll back their DB.
    
    In this case though, I think it's fine to just move the migration around
    to v49, then we can backport it to 49 and 50.
    johnswanson committed May 21, 2024
    Configuration menu
    Copy the full SHA
    05734a3 View commit details
    Browse the repository at this point in the history