Fix data labels too dense with large single series #42985
Merged
+607
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseSDevaney
added
backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2c1333e...60f4344.
|
|
kulyk
approved these changes
May 22, 2024
alxnddr
reviewed
May 22, 2024
frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts
Outdated
Show resolved
Hide resolved
alxnddr
requested changes
May 22, 2024
JesseSDevaney
force-pushed
the
fix-40196/data-labels-too-dense-with-large-single-series
branch
from
a0a5c8e
to
35a8b6d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JesseSDevaney
force-pushed
the
fix-40196/data-labels-too-dense-with-large-single-series
branch
from
0f8331d
to
9ece4d5
Compare
JesseSDevaney
force-pushed
the
fix-40196/data-labels-too-dense-with-large-single-series
branch
from
9ece4d5
to
9d1c2c2
Compare
alxnddr
reviewed
May 31, 2024
alxnddr
reviewed
May 31, 2024
frontend/src/metabase/visualizations/echarts/cartesian/model/types.ts
Outdated
Show resolved
Hide resolved
alxnddr
approved these changes
May 31, 2024
alxnddr
reviewed
May 31, 2024
| index a75f606..57bec85 100644 | ||
| --- a/node_modules/echarts/lib/label/labelLayoutHelper.js | ||
| +++ b/node_modules/echarts/lib/label/labelLayoutHelper.js | ||
| @@ -256,6 +256,13 @@ export function hideOverlap(labelList) { |
There was a problem hiding this comment.
It would be possible to get this behavior without patching ECharts by using labelLayout and shifting empty labels to one single place outside of the chart but it would be quite hackish. So I agree that ECharts should ignore empty labels when computing layout
JesseSDevaney
deleted the
fix-40196/data-labels-too-dense-with-large-single-series
branch
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-automation-metabase
pushed a commit
that referenced
this pull request
Jun 1, 2024
* remove unused variable * conditionally render labels sparsely if large amount of data points * update loki snapshots * refactor data label formatter conditions * setup intelligent label plotting * handle the case when there are no labels * add sparse data label rendering to bar charts * do not compute if no labels need to be shown or hidden * add sparse data labeling to waterfall charts * adjustment for large series waterfall labels * revert change * refactor name * add sparse labels to stacked bar and area * improve scaleFactor * fix type errors * remove unused labelFormatter * update snapshots * patch ECharts - labels with no text, i.e. "", were still being considered as plot-able labels which was causing labels with real text "asdfec.." to be hidden because of overlap. - This patch makes it so that labels with no text, i.e. "", are not considered to be candidates for overlap checking. * update loki snapshots * only loop over dataset once for getWaterfallChartDataDensity * improve performance of chart data density calculations * update loki snapshots * update E2E spec * update E2E spec * increase cartesian label density allotment * update loki snapshots * update loki snapshots * comment out node_modules cache since it cannot be skipped by commit and is breaking CI * fix type errors * Reset node modules if patches are changed * refactor type naming --------- Co-authored-by: Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
JesseSDevaney
added a commit
that referenced
this pull request
Jun 1, 2024
* remove unused variable * conditionally render labels sparsely if large amount of data points * update loki snapshots * refactor data label formatter conditions * setup intelligent label plotting * handle the case when there are no labels * add sparse data label rendering to bar charts * do not compute if no labels need to be shown or hidden * add sparse data labeling to waterfall charts * adjustment for large series waterfall labels * revert change * refactor name * add sparse labels to stacked bar and area * improve scaleFactor * fix type errors * remove unused labelFormatter * update snapshots * patch ECharts - labels with no text, i.e. "", were still being considered as plot-able labels which was causing labels with real text "asdfec.." to be hidden because of overlap. - This patch makes it so that labels with no text, i.e. "", are not considered to be candidates for overlap checking. * update loki snapshots * only loop over dataset once for getWaterfallChartDataDensity * improve performance of chart data density calculations * update loki snapshots * update E2E spec * update E2E spec * increase cartesian label density allotment * update loki snapshots * update loki snapshots * comment out node_modules cache since it cannot be skipped by commit and is breaking CI * fix type errors * Reset node modules if patches are changed * refactor type naming --------- Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by: Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo (updated)
2024-05-24.19-58-57.mp4