[Metrics V2] Port Legacy metric tests and fixes #43094
Merged
+227
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamben
approved these changes
May 23, 2024
Comment on lines
80
to
81
| (let [metadata-type (case macro-type | ||
| :metric :metadata/legacy-metric | ||
| :segment :metadata/segment)] |
There was a problem hiding this comment.
This will look quite surprising to the uninitiated.
Comment on lines
381
to
386
| {:keys [before after]} {:before {:source-table (meta/id :venues) | ||
| :aggregation [[:metric (:id source-metric)]]} | ||
| :after {:source-table (meta/id :venues) | ||
| :aggregation [[:aggregation-options [:sum [:field (meta/id :venues :price) {}]] | ||
| {:display-name "My Cool Aggregation"}]] | ||
| :filter [:= [:field (meta/id :venues :name) {}] [:value "abc" {}]]}} |
There was a problem hiding this comment.
Why not just define before and after separately?
|
|
@snoe Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43093
Errors fixed: